Skip to content

Update the tests to use WireMock 3.0.0 release#72

Merged
oleg-nenashev merged 9 commits into
mainfrom
wiremock-3-by-default
Aug 9, 2024
Merged

Update the tests to use WireMock 3.0.0 release#72
oleg-nenashev merged 9 commits into
mainfrom
wiremock-3-by-default

Conversation

@oleg-nenashev
Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev commented Aug 30, 2023

References

  • TODO

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev oleg-nenashev mentioned this pull request Aug 30, 2023
Closed
oleg-nenashev
oleg-nenashev commented Aug 31, 2023
View reviewed changes
Comment thread pom.xml Outdated
@oleg-nenashev oleg-nenashev marked this pull request as ready for review August 31, 2023 15:57
@oleg-nenashev oleg-nenashev added the chore Maintenance label Aug 31, 2023
oleg-nenashev
oleg-nenashev commented Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should stop hardcoding JAR versions...

Comment thread ...ava/org/wiremock/integrations/testcontainers/WireMockContainerExtensionsCombinationTest.java Outdated
Comment thread ...st/java/org/wiremock/integrations/testcontainers/WireMockContainerExtensionsWebhookTest.java Outdated
oleg-nenashev
oleg-nenashev commented Aug 31, 2023
View reviewed changes
Comment thread src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java Outdated
oleg-nenashev
oleg-nenashev commented Aug 31, 2023
View reviewed changes
Comment thread src/test/java/org/wiremock/integrations/testcontainers/TestConfig.java Outdated
bitxon
bitxon reviewed Sep 25, 2023
View reviewed changes
Comment thread src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java
/**
* @deprecated Not really guaranteed to be latest. Will be reworked
*/
@Deprecated
Copy link
Copy Markdown
Contributor

@bitxon bitxon Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it, since we haven't yet released - we could afford removing old code

Copy link
Copy Markdown
Member Author

@oleg-nenashev oleg-nenashev Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@oleg-nenashev
Copy link
Copy Markdown
Member Author

oleg-nenashev commented Aug 9, 2024

Thanks @graric! I think it is good to go given the time WireMock 3 has been around

@oleg-nenashev oleg-nenashev merged commit 95fe426 into main Aug 9, 2024
@oleg-nenashev oleg-nenashev deleted the wiremock-3-by-default branch August 9, 2024 21:01
@oleg-nenashev oleg-nenashev added dependencies Pull requests that update a dependency file enhancement New feature or request and removed chore Maintenance dependencies Pull requests that update a dependency file labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bitxon bitxon bitxon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

wiremock-testcontainers-1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oleg-nenashev @bitxon @graric